validate:launcher: Do not copy logs for non flaky tests

That looks weird for users and is incorrect
This commit is contained in:
Thibault Saunier 2019-04-15 16:13:48 -04:00
parent 81b1368237
commit 3fa393c498

View File

@ -1975,16 +1975,17 @@ class _TestsLauncher(Loggable):
return False return False
if retry_on_failures: if retry_on_failures:
if not self.options.redirect_logs: if not self.options.redirect_logs and test.allow_flakiness:
test.copy_logfiles() test.copy_logfiles()
printc(test) printc(test)
test.clean()
to_retry.append(test) to_retry.append(test)
# Not adding to final report if flakiness is tolerated # Not adding to final report if flakiness is tolerated
to_report = not test.allow_flakiness to_report = not test.allow_flakiness
if to_report: if to_report:
self.reporter.after_test(test) self.reporter.after_test(test)
if retry_on_failures:
test.clean()
if self.start_new_job(tests_left): if self.start_new_job(tests_left):
jobs_running += 1 jobs_running += 1