FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

validate: Don't leak discoverer information

Browse Source 
The various streaminfo were being overwritten without being unreffed first

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3390>
This commit is contained in:
Edward Hervey 2022-11-12 10:40:22 +01:00
parent 00133ebbe4
commit 3f95779c30
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
subprojects/gst-devtools/validate/gst/validate/media-descriptor-writer.c
View File

@ -735,17 +735,25 @@ gst_validate_media_descriptor_writer_new_discover (GstValidateRunner * runner,
gst_validate_media_descriptor_writer_add_stream (writer, streaminfo); gst_validate_media_descriptor_writer_add_stream (writer, streaminfo);
} }
} else { } else {
GstDiscovererStreamInfo *nextinfo;
if (!GST_IS_DISCOVERER_AUDIO_INFO (info) if (!GST_IS_DISCOVERER_AUDIO_INFO (info)
&& !GST_IS_DISCOVERER_AUDIO_INFO (info) && !GST_IS_DISCOVERER_VIDEO_INFO (info)) {
&& gst_discoverer_stream_info_get_next (streaminfo)) { nextinfo = gst_discoverer_stream_info_get_next (streaminfo);
gst_validate_media_descriptor_get_file_node ((GstValidateMediaDescriptor if (nextinfo) {
*) writer)->caps = GstValidateMediaFileNode *fn =
gst_discoverer_stream_info_get_caps (streaminfo); gst_validate_media_descriptor_get_file_node (
streaminfo = gst_discoverer_stream_info_get_next (streaminfo); (GstValidateMediaDescriptor *) writer);
fn->caps = gst_discoverer_stream_info_get_caps (streaminfo);
gst_discoverer_stream_info_unref (streaminfo);
streaminfo = nextinfo;
}
} }
do { do {
gst_validate_media_descriptor_writer_add_stream (writer, streaminfo); gst_validate_media_descriptor_writer_add_stream (writer, streaminfo);
} while ((streaminfo = gst_discoverer_stream_info_get_next (streaminfo))); nextinfo = gst_discoverer_stream_info_get_next (streaminfo);
gst_discoverer_stream_info_unref (streaminfo);
streaminfo = nextinfo;
} while (streaminfo);
} }
} else { } else {
GST_VALIDATE_REPORT (writer, FILE_NO_STREAM_INFO, GST_VALIDATE_REPORT (writer, FILE_NO_STREAM_INFO,