From 3e83d7d0bca4f8b12b6f84a6a7528de16247b57f Mon Sep 17 00:00:00 2001
From: Edward Hervey <edward@centricular.com>
Date: Sun, 5 Jan 2025 12:09:28 +0100
Subject: [PATCH] isacdec: Remove impossible check

WebRtcIsac_DecodePlc() never returns a negative value (confirmed by
documentation and current/historical code)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8229>
---
 subprojects/gst-plugins-bad/ext/isac/gstisacdec.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/subprojects/gst-plugins-bad/ext/isac/gstisacdec.c b/subprojects/gst-plugins-bad/ext/isac/gstisacdec.c
index 8b580aa6ff..47ad6ff677 100644
--- a/subprojects/gst-plugins-bad/ext/isac/gstisacdec.c
+++ b/subprojects/gst-plugins-bad/ext/isac/gstisacdec.c
@@ -187,14 +187,7 @@ gst_isacdec_plc (GstIsacDec * self, GstClockTime duration)
 
   gst_buffer_unmap (output, &map_write);
 
-  if (ret < 0) {
-    /* error */
-    gint16 code = WebRtcIsac_GetErrorCode (self->isac);
-    GST_WARNING_OBJECT (self, "Failed to produce PLC: %s (%d)",
-        isac_error_code_to_str (code), code);
-    gst_buffer_unref (output);
-    return GST_FLOW_ERROR;
-  } else if (ret == 0) {
+  if (ret == 0) {
     GST_DEBUG_OBJECT (self, "Decoder didn't produce any PLC frame");
     gst_buffer_unref (output);
     return GST_FLOW_OK;