From 3da48e7d6134397d5f8686f1421bcaec4c647349 Mon Sep 17 00:00:00 2001 From: Stefan Sauer Date: Wed, 28 Sep 2016 20:34:53 +0200 Subject: [PATCH] debug-viewer: cleanup imports in plugins Don't use * imports. Don't rely on package level imports. --- debug-viewer/GstDebugViewer/Plugins/FileProperties.py | 5 ++++- debug-viewer/GstDebugViewer/Plugins/FindBar.py | 3 ++- debug-viewer/GstDebugViewer/Plugins/Timeline.py | 7 ++++--- debug-viewer/GstDebugViewer/Plugins/__init__.py | 1 - 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/debug-viewer/GstDebugViewer/Plugins/FileProperties.py b/debug-viewer/GstDebugViewer/Plugins/FileProperties.py index 34b8d8c3be..fe62f051f4 100644 --- a/debug-viewer/GstDebugViewer/Plugins/FileProperties.py +++ b/debug-viewer/GstDebugViewer/Plugins/FileProperties.py @@ -19,8 +19,11 @@ """GStreamer Debug Viewer file properties plugin.""" -from GstDebugViewer.Plugins import * import logging + +from GstDebugViewer.Plugins import FeatureBase, PluginBase + +from gettext import gettext as _ from gi.repository import Gtk class FilePropertiesSentinel (object): diff --git a/debug-viewer/GstDebugViewer/Plugins/FindBar.py b/debug-viewer/GstDebugViewer/Plugins/FindBar.py index d6ae27c654..4e7f5a0704 100644 --- a/debug-viewer/GstDebugViewer/Plugins/FindBar.py +++ b/debug-viewer/GstDebugViewer/Plugins/FindBar.py @@ -22,8 +22,9 @@ import logging from GstDebugViewer import Common, Data, GUI -from GstDebugViewer.Plugins import * +from GstDebugViewer.Plugins import FeatureBase, PluginBase, _N +from gettext import gettext as _ from gi.repository import GObject, GLib from gi.repository import Gtk diff --git a/debug-viewer/GstDebugViewer/Plugins/Timeline.py b/debug-viewer/GstDebugViewer/Plugins/Timeline.py index e8fd194112..acd8c1795e 100644 --- a/debug-viewer/GstDebugViewer/Plugins/Timeline.py +++ b/debug-viewer/GstDebugViewer/Plugins/Timeline.py @@ -23,8 +23,9 @@ import logging from GstDebugViewer import Common, Data from GstDebugViewer.GUI.colors import LevelColorThemeTango, ThreadColorThemeTango -from GstDebugViewer.Plugins import * +from GstDebugViewer.Plugins import FeatureBase, PluginBase +from gettext import gettext as _ from gi.repository import GObject from gi.repository import Gtk from gi.repository import Gdk @@ -356,7 +357,7 @@ class VerticalTimelineWidget (Gtk.DrawingArea): self.queue_draw () return False - + def do_get_preferred_width (self): return 64, 64 # FIXME @@ -533,7 +534,7 @@ class TimelineWidget (Gtk.DrawingArea): ctx.set_source_surface (self.__offscreen) ctx.rectangle (rect.x, rect.y, rect.width, rect.height) ctx.paint () - + self.__draw_position (ctx, clip = rect) def update (self, model): diff --git a/debug-viewer/GstDebugViewer/Plugins/__init__.py b/debug-viewer/GstDebugViewer/Plugins/__init__.py index 0879f3e087..e2b7fefeca 100644 --- a/debug-viewer/GstDebugViewer/Plugins/__init__.py +++ b/debug-viewer/GstDebugViewer/Plugins/__init__.py @@ -22,7 +22,6 @@ __all__ = ["_", "_N", "FeatureBase", "PluginBase"] import os.path -from gettext import gettext as _ def _N (s): return s