From 3cebfc7e848d2e524326569cd83d9ccb5def70c7 Mon Sep 17 00:00:00 2001 From: He Junyan Date: Thu, 1 Jun 2023 18:52:28 +0800 Subject: [PATCH] glupload: Delete the flag of METHOD_FLAG_CAN_ACCEPT_RAW for DMABuf When this flag is enabled, the transform_caps() simply set passthrough to generate the raw caps. This is not correct, because the sink and src have different format/drm-format fields. We already add system memory conversion for DMABuf manner, so no more need for this flag. Part-of: --- subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c b/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c index 54a08390ac..1a4f13b5a0 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/gl/gstglupload.c @@ -1601,7 +1601,7 @@ _dma_buf_upload_free (gpointer impl) static const UploadMethod _dma_buf_upload = { "Dmabuf", - METHOD_FLAG_CAN_ACCEPT_RAW, + 0, &_dma_buf_upload_caps, &_dma_buf_upload_new, &_dma_buf_upload_transform_caps, @@ -1746,7 +1746,7 @@ _direct_dma_buf_upload_transform_caps (gpointer impl, GstGLContext * context, static const UploadMethod _direct_dma_buf_upload = { "DirectDmabuf", - METHOD_FLAG_CAN_ACCEPT_RAW, + 0, &_dma_buf_upload_caps, &_direct_dma_buf_upload_new, &_direct_dma_buf_upload_transform_caps, @@ -1768,7 +1768,7 @@ _direct_dma_buf_external_upload_new (GstGLUpload * upload) static const UploadMethod _direct_dma_buf_external_upload = { "DirectDmabufExternal", - METHOD_FLAG_CAN_ACCEPT_RAW, + 0, &_dma_buf_upload_caps, &_direct_dma_buf_external_upload_new, &_direct_dma_buf_upload_transform_caps,