From 3bf12a1b9f04ba269cbed538269a454b3ecfa51b Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Wed, 22 Jul 2015 16:10:35 +0100 Subject: [PATCH] liveadder: remove unneeded variable ret is declared just to initialize to TRUE and overwrite with the value of vret. We can return the value of vret directly. vret is TRUE unless the forward_event_func sets it to FALSE. --- gst/liveadder/liveadder.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/gst/liveadder/liveadder.c b/gst/liveadder/liveadder.c index 12e4ace6e1..1de6fe8209 100644 --- a/gst/liveadder/liveadder.c +++ b/gst/liveadder/liveadder.c @@ -823,24 +823,19 @@ forward_event_func (const GValue * item, GValue * ret, gpointer user_data) static gboolean forward_event (GstLiveAdder * adder, GstEvent * event) { - gboolean ret; GstIterator *it; GValue vret = { 0 }; GST_LOG_OBJECT (adder, "Forwarding event %p (%s)", event, GST_EVENT_TYPE_NAME (event)); - ret = TRUE; - g_value_init (&vret, G_TYPE_BOOLEAN); g_value_set_boolean (&vret, TRUE); it = gst_element_iterate_sink_pads (GST_ELEMENT_CAST (adder)); gst_iterator_fold (it, forward_event_func, &vret, event); gst_iterator_free (it); - ret = g_value_get_boolean (&vret); - - return ret; + return g_value_get_boolean (&vret); }