From 3b6825a5465bddce5e48965370e74a8e9bf01db8 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Wed, 24 Jul 2013 17:49:59 +0200 Subject: [PATCH] codecparser: Make warnings more meaningful By stating whether we don't have enough data or it's a corrupted packet --- gst-libs/gst/codecparsers/gstmpegvideoparser.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gst-libs/gst/codecparsers/gstmpegvideoparser.c b/gst-libs/gst/codecparsers/gstmpegvideoparser.c index 889358a187..af31911545 100644 --- a/gst-libs/gst/codecparsers/gstmpegvideoparser.c +++ b/gst-libs/gst/codecparsers/gstmpegvideoparser.c @@ -849,7 +849,7 @@ gst_mpeg_video_packet_parse_picture_header (const GstMpegVideoPacket * packet, if (hdr->pic_type == 0 || hdr->pic_type > 4) - goto failed; /* Corrupted picture packet */ + goto bad_pic_type; /* Corrupted picture packet */ /* skip VBV delay */ if (!gst_bit_reader_skip (&br, 16)) @@ -879,9 +879,15 @@ gst_mpeg_video_packet_parse_picture_header (const GstMpegVideoPacket * packet, return TRUE; +bad_pic_type: + { + GST_WARNING ("Unsupported picture type : %d", hdr->pic_type); + return FALSE; + } + failed: { - GST_WARNING ("Failed to parse picture header"); + GST_WARNING ("Not enough data to parse picture header"); return FALSE; } }