From 3b47b8703811ff7a2faff31eae5c5bc9e6f222f4 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Wed, 3 Jul 2024 09:05:06 +0200 Subject: [PATCH] downloadbuffer: send EOS in push mode gst_download_buffer_read_buffer() returns FLOW_EOS but it was not handled in the 'out_flushing' goto block which uses srcresult, so EOS was not sent downstream. Part-of: --- subprojects/gstreamer/plugins/elements/gstdownloadbuffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/subprojects/gstreamer/plugins/elements/gstdownloadbuffer.c b/subprojects/gstreamer/plugins/elements/gstdownloadbuffer.c index 35e7f3ebbf..b25aadf2f8 100644 --- a/subprojects/gstreamer/plugins/elements/gstdownloadbuffer.c +++ b/subprojects/gstreamer/plugins/elements/gstdownloadbuffer.c @@ -1325,8 +1325,10 @@ gst_download_buffer_loop (GstPad * pad) GST_DOWNLOAD_BUFFER_MUTEX_LOCK_CHECK (dlbuf, dlbuf->srcresult, out_flushing); ret = gst_download_buffer_read_buffer (dlbuf, -1, -1, &buffer); - if (ret != GST_FLOW_OK) + if (ret != GST_FLOW_OK) { + dlbuf->srcresult = ret; goto out_flushing; + } if (dlbuf->stream_start_event != NULL) { gst_pad_push_event (dlbuf->srcpad, dlbuf->stream_start_event);