From 3a119b20b3115d57abf979a494b1eb0fb26e46bb Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Tue, 19 Nov 2024 13:47:55 +0100 Subject: [PATCH] ccutils: Remove broken branch This branch was added in dd00dab5e9e8650f3f00660c2e611f81f1e8cd5b but is never actually taken, as it requires `cc_data` to be null but `cc_data_len` to be non-null. It would then dereference the null `cc_data`. Part-of: --- .../gst-plugins-bad/ext/closedcaption/ccutils.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/closedcaption/ccutils.c b/subprojects/gst-plugins-bad/ext/closedcaption/ccutils.c index 959b767e71..7564793130 100644 --- a/subprojects/gst-plugins-bad/ext/closedcaption/ccutils.c +++ b/subprojects/gst-plugins-bad/ext/closedcaption/ccutils.c @@ -921,16 +921,6 @@ cc_buffer_take_separated (CCBuffer * buf, } } *cc_data_len = write_ccp_size + ccp_padding; - } else if (buf->output_padding) { - guint i; - guint padding = 3 * fps_entry->max_ccp_count; - for (i = 0; i < padding; i += 3) { - cc_data[i + write_ccp_size] = 0xfa; - cc_data[i + 1 + write_ccp_size] = 0x00; - cc_data[i + 2 + write_ccp_size] = 0x00; - } - GST_TRACE_OBJECT (buf, "outputting only %u padding bytes", padding); - *cc_data_len = padding; } else { *cc_data_len = 0; }