From 380a9471550303cb1f773ceb3aa10d25a74ed2b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pablo=20Garc=C3=ADa?= <pgarcia@fluendo.com>
Date: Tue, 11 Mar 2025 15:02:03 +0100
Subject: [PATCH] curl: use CURL_SOCKET_BAD to ensure cross-platform

Solves this error in Windows build:
        ../ext/curl/gstcurlbasesink.c:1154:14: error: comparison of unsigned
        expression in '< 0' is always false [-Werror=type-limits]
        1154 |   if (curlfd < 0) {

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8615>
---
 subprojects/gst-plugins-bad/ext/curl/gstcurlbasesink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/subprojects/gst-plugins-bad/ext/curl/gstcurlbasesink.c b/subprojects/gst-plugins-bad/ext/curl/gstcurlbasesink.c
index 787b34fea3..29d163ecc4 100644
--- a/subprojects/gst-plugins-bad/ext/curl/gstcurlbasesink.c
+++ b/subprojects/gst-plugins-bad/ext/curl/gstcurlbasesink.c
@@ -1151,7 +1151,7 @@ gst_curl_base_sink_transfer_socket_cb (void *clientp, curl_socket_t curlfd,
 
   g_assert (sink);
 
-  if (curlfd < 0) {
+  if (curlfd == CURL_SOCKET_BAD) {
     /* signal an unrecoverable error to the library which will close the socket
        and return CURLE_COULDNT_CONNECT
      */