From 3138c4e696982684c57a9846d7dff2d59faf6f1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 25 Oct 2012 17:14:32 +0100 Subject: [PATCH] pango: avoid unnecessary pango attribute list copy We just want to keep it alive, not modify it, so a simple ref should be enough. https://bugzilla.gnome.org/show_bug.cgi?id=686841 --- ext/pango/gstbasetextoverlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/pango/gstbasetextoverlay.c b/ext/pango/gstbasetextoverlay.c index ebf8b9cb1c..5d08e951ba 100644 --- a/ext/pango/gstbasetextoverlay.c +++ b/ext/pango/gstbasetextoverlay.c @@ -1380,7 +1380,7 @@ gst_base_text_overlay_render_pangocairo (GstBaseTextOverlay * overlay, PangoAttrList *origin_attr, *filtered_attr; origin_attr = - pango_attr_list_copy (pango_layout_get_attributes (overlay->layout)); + pango_attr_list_ref (pango_layout_get_attributes (overlay->layout)); filtered_attr = pango_attr_list_filter (pango_attr_list_copy (origin_attr), gst_text_overlay_filter_foreground_attr, NULL);