From 30a00b6a9750701a383483fcac32ce1f5d910ff9 Mon Sep 17 00:00:00 2001 From: Jochen Henneberg <jochen@centricular.com> Date: Tue, 28 Jan 2025 11:45:32 +0100 Subject: [PATCH] validate: Don't print to stdout on bail out Otherwise, if the output is multiline like from expected/actual file comparison mismatch, meson will parse the lines for TAP formatted strings and report an error. In that case the tests is accidently SKIPPED instead of FAIL. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8376> --- .../gst-devtools/validate/gst/validate/gst-validate-report.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-devtools/validate/gst/validate/gst-validate-report.c b/subprojects/gst-devtools/validate/gst/validate/gst-validate-report.c index e5a59eb233..a131d95efb 100644 --- a/subprojects/gst-devtools/validate/gst/validate/gst-validate-report.c +++ b/subprojects/gst-devtools/validate/gst/validate/gst-validate-report.c @@ -1538,7 +1538,8 @@ gst_validate_error_structure (gpointer structure, const gchar * format, ...) if (debug) g_string_append (f, debug); - g_print ("Bail out! %sERROR%s: %s\n\n", color ? color : "", endcolor, f->str); + g_printerr ("Bail out! %sERROR%s: %s\n\n", color ? color : "", endcolor, + f->str); g_string_free (f, TRUE); g_free (debug); g_free (color); @@ -1558,7 +1559,7 @@ gst_validate_abort (const gchar * format, ...) tmp = gst_info_strdup_vprintf (format, var_args); va_end (var_args); - g_print ("Bail out! %s\n", tmp); + g_printerr ("Bail out! %s\n", tmp); g_free (tmp); exit (-18); }