From 2ec51ef998caa7530ff2caf8c7025b883d7f6f04 Mon Sep 17 00:00:00 2001 From: shakin chou Date: Fri, 3 Nov 2017 11:39:54 +0800 Subject: [PATCH] playbin: Don't ref_sink() the sinks twice Since we're already sunk floating reference, we shouldn't call ref_sink again, which increases the ref_count and cause leaks. https://bugzilla.gnome.org/show_bug.cgi?id=789547 --- gst/playback/gstplaybin2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c index 46da78e95f..a2e9ed4453 100644 --- a/gst/playback/gstplaybin2.c +++ b/gst/playback/gstplaybin2.c @@ -4663,7 +4663,6 @@ autoplug_select_cb (GstElement * decodebin, GstPad * pad, gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (ave->sink))); continue; } - gst_object_ref_sink (*sinkp); created_sink = TRUE; } }