From 27f4fb060dfc1101b44b7d150cd1a2c4ce12fdc5 Mon Sep 17 00:00:00 2001
From: Matthew Waters <matthew@centricular.com>
Date: Wed, 28 Aug 2019 20:09:39 +1000
Subject: [PATCH] avfvideosrc: don't leak texture caches

If decide_allocation is called multiple times, then we would continually
overwrite the previous cache without freeing
---
 sys/applemedia/avfvideosrc.m | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/applemedia/avfvideosrc.m b/sys/applemedia/avfvideosrc.m
index 65e46de343..749fb6a233 100644
--- a/sys/applemedia/avfvideosrc.m
+++ b/sys/applemedia/avfvideosrc.m
@@ -1095,7 +1095,8 @@ didOutputSampleBuffer:(CMSampleBufferRef)sampleBuffer
       gst_video_texture_cache_free (textureCache);
       textureCache = NULL;
     }
-    textureCache = gst_video_texture_cache_new (ctxh->context);
+    if (!textureCache)
+      textureCache = gst_video_texture_cache_new (ctxh->context);
     gst_video_texture_cache_set_format (textureCache, format, alloc_caps);
   }