From 261431ef17ebf520ee1b0f7df7aba0dadaa193e2 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Mon, 21 Mar 2011 10:38:58 +0100 Subject: [PATCH] mpeg2enc: Lower the rank to MARGINAL The rationale is that it can't be properly used right now when using it to encode mpeg2video because of the needs-to-be-rewritten properties and format negotiation. Other encoders will negotiate in a much saner fashion. One such example is that when you pick mpeg2enc for mpeg2video, the default value for the 'format' property is "Generic MPEG-1", which is completely wrong if downstream caps are mpeg2. The whole negotiation code needs some serious loving before this plugin can be bumped back up to a higher rank. --- ext/mpeg2enc/gstmpeg2enc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/mpeg2enc/gstmpeg2enc.cc b/ext/mpeg2enc/gstmpeg2enc.cc index 64008b1644..5c0b426e93 100644 --- a/ext/mpeg2enc/gstmpeg2enc.cc +++ b/ext/mpeg2enc/gstmpeg2enc.cc @@ -717,7 +717,7 @@ plugin_init (GstPlugin * plugin) mjpeg_default_handler_verbosity (0); return gst_element_register (plugin, "mpeg2enc", - GST_RANK_SECONDARY, GST_TYPE_MPEG2ENC); + GST_RANK_MARGINAL, GST_TYPE_MPEG2ENC); } GST_PLUGIN_DEFINE (GST_VERSION_MAJOR,