FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

openh264: Ensure src_pic is initialized before use

Browse Source 
valgrind was showing reads of uninitialized memory and the
library examples all memset the structure before use.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9352>
This commit is contained in:
Doug Nazar 2025-06-17 06:38:59 -04:00 committed by GStreamer Marge Bot
parent d694a38cc3
commit 24dcc0a009
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
subprojects/gst-plugins-bad/ext/openh264/gstopenh264enc.cpp
View File

@ -922,7 +922,7 @@ gst_openh264enc_handle_frame (GstVideoEncoder * encoder,
GST_OBJECT_UNLOCK (openh264enc);
if (frame) {
src_pic = new SSourcePicture;
src_pic = g_new0 (SSourcePicture, 1);
if (src_pic == NULL) {
if (frame)
@ -977,7 +977,7 @@ gst_openh264enc_handle_frame (GstVideoEncoder * encoder,
if (frame) {
gst_video_frame_unmap (&video_frame);
gst_video_codec_frame_unref (frame);
delete src_pic;
g_free (src_pic);
GST_ELEMENT_ERROR (openh264enc, STREAM, ENCODE,
("Could not encode frame"), ("Openh264 returned %d", ret));
return GST_FLOW_ERROR;
@ -990,7 +990,7 @@ gst_openh264enc_handle_frame (GstVideoEncoder * encoder,
if (frame) {
gst_video_frame_unmap (&video_frame);
gst_video_encoder_finish_frame (encoder, frame);
delete src_pic;
g_free (src_pic);
}
return GST_FLOW_OK;
@ -999,7 +999,7 @@ gst_openh264enc_handle_frame (GstVideoEncoder * encoder,
if (frame) {
gst_video_frame_unmap (&video_frame);
gst_video_codec_frame_unref (frame);
delete src_pic;
g_free (src_pic);
src_pic = NULL;
frame = NULL;
}