From 23a006c64f9fbef534ccec0612d72a2b2b092029 Mon Sep 17 00:00:00 2001 From: Nirbheek Chauhan Date: Tue, 26 Nov 2024 16:52:05 +0530 Subject: [PATCH] meson: Don't unconditionally invoke the libsoup subproject fallback: kwarg will invoke the specified subproject even if required: false, which is not what we want here. Reported at https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4045#note_2674340 Part-of: --- subprojects/gst-plugins-bad/tests/check/meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/tests/check/meson.build b/subprojects/gst-plugins-bad/tests/check/meson.build index c0a5a00a12..7bbbea34c3 100644 --- a/subprojects/gst-plugins-bad/tests/check/meson.build +++ b/subprojects/gst-plugins-bad/tests/check/meson.build @@ -16,8 +16,7 @@ exif_dep = dependency('libexif', version : '>= 0.6.16', required : false) nalutils_dep = gstcodecparsers_dep.partial_dependency (compile_args: true, includes: true) enable_gst_play_tests = get_option('gst_play_tests') -libsoup_dep = dependency('libsoup-2.4', version : '>=2.48', required : enable_gst_play_tests, - fallback : ['libsoup', 'libsoup_dep']) +libsoup_dep = dependency('libsoup-2.4', version: '>=2.48', required: enable_gst_play_tests) # name, condition when to skip the test and extra dependencies base_tests = [