From 232bdf17115419da61c3b1ce2c5b02d74e34d403 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Thu, 30 Jul 2015 12:50:56 +0100 Subject: [PATCH] rtpbasedepayload: fix leaks in error code paths This was introduced when reshuffling the buffer unmaps in commit bc14cdf529e21356ea7b2c8f34614958a91f7260 rtp: rtpbasedepayload: add process_rtp_packet() vfunc Fixes make check-valgrind. https://bugzilla.gnome.org/show_bug.cgi?id=750235 --- gst-libs/gst/rtp/gstrtpbasedepayload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst-libs/gst/rtp/gstrtpbasedepayload.c b/gst-libs/gst/rtp/gstrtpbasedepayload.c index 95d260dbaa..fac757d459 100644 --- a/gst-libs/gst/rtp/gstrtpbasedepayload.c +++ b/gst-libs/gst/rtp/gstrtpbasedepayload.c @@ -487,11 +487,13 @@ invalid_buffer: } dropping: { + gst_rtp_buffer_unmap (&rtp); GST_WARNING_OBJECT (filter, "%d <= 100, dropping old packet", gap); return GST_FLOW_OK; } no_process: { + gst_rtp_buffer_unmap (&rtp); /* this is not fatal but should be filtered earlier */ GST_ELEMENT_ERROR (filter, STREAM, NOT_IMPLEMENTED, (NULL), ("The subclass does not have a process or process_rtp_packet method"));