From 20298ee810e7a3ae1e1a156b516546b09999079c Mon Sep 17 00:00:00 2001 From: julien Date: Sat, 13 Dec 2008 19:36:32 -0500 Subject: [PATCH] [287/906] fix a regression about glXChooseVisual which failed when using mesa, so attributes must be less restrictives. --- gst-libs/gst/gl/gstglwindow_x11.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/gst-libs/gst/gl/gstglwindow_x11.c b/gst-libs/gst/gl/gstglwindow_x11.c index e728239fc5..b98aac4d9e 100644 --- a/gst-libs/gst/gl/gstglwindow_x11.c +++ b/gst-libs/gst/gl/gstglwindow_x11.c @@ -251,16 +251,8 @@ gst_gl_window_new (gint width, gint height) gint attrib[] = { GLX_RGBA, - GLX_RED_SIZE, 8, GLX_GREEN_SIZE, 8, GLX_BLUE_SIZE, 8, + GLX_RED_SIZE, 1, GLX_GREEN_SIZE, 1, GLX_BLUE_SIZE, 1, GLX_DOUBLEBUFFER, - GLX_DEPTH_SIZE, 8, - GLX_ALPHA_SIZE, 8, - GLX_STENCIL_SIZE, 8, - GLX_ACCUM_RED_SIZE, 8, - GLX_ACCUM_GREEN_SIZE, 8, - GLX_ACCUM_BLUE_SIZE, 8, - GLX_ACCUM_ALPHA_SIZE, 8, - GLX_LEVEL, 0, None }; @@ -322,6 +314,12 @@ gst_gl_window_new (gint width, gint height) priv->visual_info = glXChooseVisual (priv->device, priv->screen_num, attrib); + if (!priv->visual_info) + { + g_warning ("glx visual is null (bad attributes)\n"); + return NULL; + } + if (priv->visual_info->visual != priv->visual) g_debug ("selected visual is different from the default\n");