From 1eeea942de79aac826ab85c5bc3ab862eb0089cc Mon Sep 17 00:00:00 2001 From: He Junyan Date: Tue, 3 Jan 2023 17:28:18 +0800 Subject: [PATCH] h265decoder: Fix a memory leak because of slice header. The gst_h265_slice_hdr_free() should free the slice header just parsed, not the priv->current_slice. Or, the memory leak will happen because we do not free the slices in priv->nalu list. Part-of: --- .../gst-plugins-bad/gst-libs/gst/codecs/gsth265decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gsth265decoder.c b/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gsth265decoder.c index 723697c614..4731300417 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gsth265decoder.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/codecs/gsth265decoder.c @@ -830,7 +830,7 @@ gst_h265_decoder_parse_slice (GstH265Decoder * self, GstH265NalUnit * nalu) * GstH265SliceHdr::entry_point_offset_minus1 but we don't use it * in this h265decoder baseclass at the moment */ - gst_h265_slice_hdr_free (&priv->current_slice.header); + gst_h265_slice_hdr_free (&slice.header); slice.nalu = *nalu; if (nalu->type >= GST_H265_NAL_SLICE_BLA_W_LP &&