FaSTTUBe/GST-Tensordecoder-ov_ep
61
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gdkpixbufdec: Check if initializing the video info actually succeeded

Browse Source 
Otherwise a 0-byte buffer would be allocated, which gives NULL memory when
mapped.

Thanks to Antonio Morales for finding and reporting the issue.

Fixes GHSL-2024-118
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3876

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8041>
This commit is contained in:
Sebastian Dröge 2024-10-02 14:44:21 +03:00 committed by GStreamer Marge Bot
parent 3cdf206f4f
commit 1d1c9d63be
1 changed files with 8 additions and 1 deletions

9
subprojects/gst-plugins-good/ext/gdk_pixbuf/gstgdkpixbufdec.c

@ -322,7 +322,8 @@ gst_gdk_pixbuf_dec_flush (GstGdkPixbufDec * filter)
gst_video_info_init (&info); gst_video_info_init (&info);
gst_video_info_set_format (&info, fmt, width, height); if (!gst_video_info_set_format (&info, fmt, width, height))
goto format_not_supported;
info.fps_n = filter->in_fps_n; info.fps_n = filter->in_fps_n;
info.fps_d = filter->in_fps_d; info.fps_d = filter->in_fps_d;
caps = gst_video_info_to_caps (&info); caps = gst_video_info_to_caps (&info);
@ -384,6 +385,12 @@ channels_not_supported:
("%d channels not supported", n_channels)); ("%d channels not supported", n_channels));
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
format_not_supported:
{
GST_ELEMENT_ERROR (filter, STREAM, DECODE, (NULL),
("%d channels with %dx%d not supported", n_channels, width, height));
return GST_FLOW_ERROR;
}
no_buffer: no_buffer:
{ {
GST_DEBUG ("Failed to create outbuffer - %s", gst_flow_get_name (ret)); GST_DEBUG ("Failed to create outbuffer - %s", gst_flow_get_name (ret));