diff --git a/tests/check/elements/rtpbin_buffer_list.c b/tests/check/elements/rtpbin_buffer_list.c index 6aa98d7aa5..b804744352 100644 --- a/tests/check/elements/rtpbin_buffer_list.c +++ b/tests/check/elements/rtpbin_buffer_list.c @@ -888,6 +888,81 @@ sink_chain_muxed_rtcp (GstPad * pad, GstObject * parent, GstBuffer * buffer) } +/* Invalid data can be received muxed with valid RTP packets */ +static GstBufferList * +create_buffer_list_muxed_invalid (void) +{ + GstBufferList *list; + GstBuffer *orig_buffer; + GstBuffer *buffer; + + guint seqnum = 0; + + orig_buffer = create_original_buffer (); + fail_if (orig_buffer == NULL); + + list = gst_buffer_list_new (); + fail_if (list == NULL); + + buffer = + create_rtp_buffer_fields (&rtp_header[0], rtp_header_len[0], + orig_buffer, payload_offset[0], payload_len[0], seqnum, 0); + gst_buffer_list_add (list, buffer); + + seqnum++; + + buffer = + create_rtp_buffer_fields (&rtp_header[0], rtp_header_len[0], + orig_buffer, payload_offset[0], payload_len[0], seqnum, 0); + gst_buffer_list_add (list, buffer); + + seqnum++; + + /* add an invalid RTP packet to the list */ + buffer = gst_buffer_new_allocate (NULL, 10, NULL); + /* initialize the memory to make valgrind happy */ + gst_buffer_memset (buffer, 0, 0, 10); + + gst_buffer_list_add (list, buffer); + + buffer = + create_rtp_buffer_fields (&rtp_header[0], rtp_header_len[0], + orig_buffer, payload_offset[0], payload_len[0], seqnum, 0); + gst_buffer_list_add (list, buffer); + + return list; +} + +/* + * Only valid RTP buffers should have been pushed to recv_rtp_src. + */ +static GstFlowReturn +sink_chain_list_muxed_invalid (GstPad * pad, GstObject * parent, + GstBufferList * list) +{ + GstBuffer *buffer; + + chain_list_func_called = TRUE; + + fail_unless (GST_IS_BUFFER_LIST (list)); + fail_unless (gst_buffer_list_length (list) == 3); + + /* Verify seqnums of valid RTP packets. */ + buffer = gst_buffer_list_get (list, 0); + check_seqnum (buffer, 0); + + buffer = gst_buffer_list_get (list, 1); + check_seqnum (buffer, 1); + + buffer = gst_buffer_list_get (list, 2); + check_seqnum (buffer, 2); + + gst_buffer_list_unref (list); + + return GST_FLOW_OK; +} + + /* Get the stats of the **first** source of the given type (get_sender) */ static void get_source_stats (GstElement * rtpsession, @@ -1476,6 +1551,54 @@ GST_START_TEST (test_bufferlist_recv_muxed_rtcp) GST_END_TEST; +GST_START_TEST (test_bufferlist_recv_muxed_invalid) +{ + GstElement *rtpbin; + GstPad *srcpad; + GstPad *sinkpad; + GstCaps *caps; + GstBufferList *list; + + list = create_buffer_list_muxed_invalid (); + fail_unless (list != NULL); + + rtpbin = gst_check_setup_element ("rtpsession"); + + srcpad = + gst_check_setup_src_pad_by_name (rtpbin, &srctemplate, "recv_rtp_sink"); + fail_if (srcpad == NULL); + + sinkpad = + gst_check_setup_sink_pad_by_name (rtpbin, &sinktemplate, "recv_rtp_src"); + fail_if (sinkpad == NULL); + + gst_pad_set_chain_list_function (sinkpad, + GST_DEBUG_FUNCPTR (sink_chain_list_muxed_invalid)); + + gst_pad_set_active (srcpad, TRUE); + gst_pad_set_active (sinkpad, TRUE); + + caps = gst_caps_from_string (TEST_CAPS); + gst_check_setup_events (srcpad, rtpbin, caps, GST_FORMAT_TIME); + gst_caps_unref (caps); + + gst_element_set_state (rtpbin, GST_STATE_PLAYING); + + chain_list_func_called = FALSE; + fail_unless (gst_pad_push_list (srcpad, list) == GST_FLOW_OK); + fail_if (chain_list_func_called == FALSE); + + gst_pad_set_active (sinkpad, FALSE); + gst_pad_set_active (srcpad, FALSE); + + gst_check_teardown_pad_by_name (rtpbin, "recv_rtp_src"); + gst_check_teardown_pad_by_name (rtpbin, "recv_rtp_sink"); + gst_check_teardown_element (rtpbin); +} + +GST_END_TEST; + + static Suite * bufferlist_suite (void) { @@ -1497,6 +1620,7 @@ bufferlist_suite (void) tcase_add_test (tc_chain, test_bufferlist_recv_reordered_packets); tcase_add_test (tc_chain, test_bufferlist_recv_different_frames); tcase_add_test (tc_chain, test_bufferlist_recv_muxed_rtcp); + tcase_add_test (tc_chain, test_bufferlist_recv_muxed_invalid); return s; }