FaSTTUBe/GST-Tensordecoder-ov_ep
39
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

webrtcbin: Include all accepted media formats in SDP answers

Browse Source 
Until this patch only the first format was added.

Fixes #4458

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9117>
This commit is contained in:
Philippe Normand 2025-06-09 13:05:47 +01:00 committed by GStreamer Marge Bot
parent fb43941e92
commit 189d33015d
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
View File

@ -4685,12 +4685,26 @@ _create_answer_task (GstWebRTCBin * webrtc, const GstStructure * options,
gst_structure_remove_fields (s, "rtcp-fb-nack", NULL); gst_structure_remove_fields (s, "rtcp-fb-nack", NULL);
} }
if (gst_sdp_media_set_media_from_caps (answer_caps, media) != GST_SDP_OK) { static const gchar *disallowed_payloads[4] = { "rtx", "red", "ulpfec",
GST_WARNING_OBJECT (webrtc, NULL
"Could not build media from caps %" GST_PTR_FORMAT, answer_caps); };
gst_clear_caps (&answer_caps); guint answer_caps_size = gst_caps_get_size (answer_caps);
gst_clear_caps (&offer_caps); for (guint l = 0; l < answer_caps_size; l++) {
goto rejected; const GstStructure *s = gst_caps_get_structure (answer_caps, l);
const gchar *enc_name = gst_structure_get_string (s, "encoding-name");
gchar *tmp = g_ascii_strdown (enc_name, -1);
if (g_strv_contains (disallowed_payloads, tmp)) {
g_free (tmp);
continue;
}
g_free (tmp);
if (gst_sdp_media_add_media_from_structure (s, media) != GST_SDP_OK) {
GST_WARNING_OBJECT (webrtc,
"Could not set media from %" GST_PTR_FORMAT, s);
gst_clear_caps (&answer_caps);
gst_clear_caps (&offer_caps);
goto rejected;
}
} }
_get_rtx_target_pt_and_ssrc_from_caps (answer_caps, &target_pt, _get_rtx_target_pt_and_ssrc_from_caps (answer_caps, &target_pt,