From 1840fa93630b5e3c2e87b011111fdba560bec6cf Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Wed, 18 May 2016 12:12:15 +0300 Subject: [PATCH] v4l2object: fix caps leak gst_v4l2_object_probe_caps() was taking an extra ref on the returned caps for no reason. https://bugzilla.gnome.org/show_bug.cgi?id=766610 --- sys/v4l2/gstv4l2object.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c index da83d08758..05258ca0d8 100644 --- a/sys/v4l2/gstv4l2object.c +++ b/sys/v4l2/gstv4l2object.c @@ -3867,9 +3867,11 @@ gst_v4l2_object_probe_caps (GstV4l2Object * v4l2object, GstCaps * filter) } if (filter) { + GstCaps *tmp; + + tmp = ret; ret = gst_caps_intersect_full (filter, ret, GST_CAPS_INTERSECT_FIRST); - } else { - ret = gst_caps_ref (ret); + gst_caps_unref (tmp); } return ret;