From 14f8172d2bd4cb9ce38f60cfe6cb6c18709c1c14 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Wed, 9 Apr 2014 17:28:49 +0100 Subject: [PATCH] smoothstreaming: avoid using an uninitialized manifest If we did not set the manifest yet, early out in the seeking query. Coverity 1139737 --- ext/smoothstreaming/gstmssdemux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/smoothstreaming/gstmssdemux.c b/ext/smoothstreaming/gstmssdemux.c index aa74164129..56889ea6ec 100644 --- a/ext/smoothstreaming/gstmssdemux.c +++ b/ext/smoothstreaming/gstmssdemux.c @@ -656,7 +656,9 @@ gst_mss_demux_src_query (GstPad * pad, GstObject * parent, GstQuery * query) GstFormat fmt; gint64 stop = -1; - if (mssdemux->manifest && gst_mss_manifest_is_live (mssdemux->manifest)) { + if (!mssdemux->manifest) { + return FALSE; /* no seeking without manifest */ + } else if (gst_mss_manifest_is_live (mssdemux->manifest)) { return FALSE; /* no live seeking */ }