From 14c097e87dffe74126f89544977d9e046b93c724 Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Thu, 24 Aug 2023 17:40:42 +0200 Subject: [PATCH] rtmp2: Allow NULL flash version, omitting the field rtmpsink omits it by default. Allow us to do the same. Part-of: --- .../gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c b/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c index 154b4d8693..fdd1419fd0 100644 --- a/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c +++ b/subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpclient.c @@ -602,13 +602,6 @@ send_connect (GTask * task) goto out; } - if (!flash_ver) { - g_task_return_new_error (task, G_IO_ERROR, G_IO_ERROR_NOT_INITIALIZED, - "Flash version is not set"); - g_object_unref (task); - goto out; - } - if (data->auth_query) { const gchar *query = data->auth_query; appstr = g_strdup_printf ("%s?%s", app, query); @@ -649,9 +642,11 @@ send_connect (GTask * task) gst_amf_node_append_field_string (node, "type", "nonprivate", -1); } - /* "Flash Player version. It is the same string as returned by the - * ApplicationScript getversion () function." */ - gst_amf_node_append_field_string (node, "flashVer", flash_ver, -1); + if (flash_ver) { + /* "Flash Player version. It is the same string as returned by the + * ApplicationScript getversion () function." */ + gst_amf_node_append_field_string (node, "flashVer", flash_ver, -1); + } /* "URL of the source SWF file making the connection." * XXX: libavformat sends "swfUrl" here, if provided. */