From 13c0f44dd546cd058c39f32101a361b3a7746f73 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Sun, 23 Mar 2025 01:59:48 +0100 Subject: [PATCH] validate: Add gst-video to Requires in pkg-config `gst/validate/validate.h` includes `gst/validate/gst-validate-media-info.h`, which in turn includes `gst/pbutils/pbutils.h` but `gstreamer-pbutils-1.0` was only listed in `Requires.private` field of `gstreamer-validate-1.0.pc`. This would cause projects linking against `gstreamer-validate-1.0.pc` to fail to find the headers when using alternative interpretation of pkg-config specification that only considers private dependencies for include path during static builds, such as the case e.g. on Nix. https://gitlab.freedesktop.org/pkg-config/pkg-config/-/issues/28 Part-of: --- subprojects/gst-devtools/validate/gst/validate/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-devtools/validate/gst/validate/meson.build b/subprojects/gst-devtools/validate/gst/validate/meson.build index 0639831030..304df8e8f2 100644 --- a/subprojects/gst-devtools/validate/gst/validate/meson.build +++ b/subprojects/gst-devtools/validate/gst/validate/meson.build @@ -103,7 +103,7 @@ plugin_sources += { pkg_name = 'gstreamer-validate-1.0' library_def = {'lib': gstvalidate} pkgconfig.generate(gstvalidate, - libraries : [gst_dep], + libraries : [gst_dep, gst_pbutils_dep, gst_video_dep], subdirs : pkgconfig_subdirs, name : pkg_name, description : 'GStreamer Validate',