From 10ce5a68576c87b475d08011f14c42c14b9ae595 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Cerveau?= Date: Tue, 30 Apr 2024 18:08:27 +0200 Subject: [PATCH] vkh26xdec: Fix stop memory leak The h26xdecoder 'stop' method was not called as the vulkan h26x class rewires the video decoder 'stop' base method to its own one. It was causing some memory leaks such as dangling parser and dpb in h26xdecoder base class. Part-of: --- subprojects/gst-plugins-bad/ext/vulkan/vkh264dec.c | 2 +- subprojects/gst-plugins-bad/ext/vulkan/vkh265dec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/vulkan/vkh264dec.c b/subprojects/gst-plugins-bad/ext/vulkan/vkh264dec.c index c966521cc2..6366732b06 100644 --- a/subprojects/gst-plugins-bad/ext/vulkan/vkh264dec.c +++ b/subprojects/gst-plugins-bad/ext/vulkan/vkh264dec.c @@ -198,7 +198,7 @@ gst_vulkan_h264_decoder_stop (GstVideoDecoder * decoder) if (self->output_state) gst_video_codec_state_unref (self->output_state); - return TRUE; + return GST_VIDEO_DECODER_CLASS (parent_class)->stop (decoder); } static void diff --git a/subprojects/gst-plugins-bad/ext/vulkan/vkh265dec.c b/subprojects/gst-plugins-bad/ext/vulkan/vkh265dec.c index f9da891ca6..703d6bd9c1 100644 --- a/subprojects/gst-plugins-bad/ext/vulkan/vkh265dec.c +++ b/subprojects/gst-plugins-bad/ext/vulkan/vkh265dec.c @@ -256,7 +256,7 @@ gst_vulkan_h265_decoder_stop (GstVideoDecoder * decoder) if (self->output_state) gst_video_codec_state_unref (self->output_state); - return TRUE; + return GST_VIDEO_DECODER_CLASS (parent_class)->stop (decoder); } static gboolean