From 0f3c34f05f71fb74f24e0ecd4867c3c53abcaf8d Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Fri, 26 Jun 2015 14:12:22 -0400 Subject: [PATCH] glimagesink: Don't leak pool gst_query_add_allocation_pool is transfer none. Also unref if there was a configuration error. --- ext/gl/gstglimagesink.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ext/gl/gstglimagesink.c b/ext/gl/gstglimagesink.c index b8fd96c4e1..41e173f66f 100644 --- a/ext/gl/gstglimagesink.c +++ b/ext/gl/gstglimagesink.c @@ -1530,11 +1530,14 @@ gst_glimage_sink_propose_allocation (GstBaseSink * bsink, GstQuery * query) config = gst_buffer_pool_get_config (pool); gst_buffer_pool_config_set_params (config, caps, size, 0, 0); - if (!gst_buffer_pool_set_config (pool, config)) + if (!gst_buffer_pool_set_config (pool, config)) { + g_object_unref (pool); goto config_failed; + } /* we need at least 2 buffer because we hold on to the last one */ gst_query_add_allocation_pool (query, pool, size, 2, 0); + g_object_unref (pool); } if (glimage_sink->context->gl_vtable->FenceSync)