From 0f1dfc2db0fb30fa8cd78933d6cdaa8cf5ee5586 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Mon, 11 Mar 2024 15:58:53 +0100 Subject: [PATCH] playbin3: Remove un-needed URI NULL check This will mimic the playbin2 behaviour, which sets the "next" entry to be NULL. The biggest impact this has is that when going back to READY the current play entry will be discarded (instead of being kept around for when you go back to PAUSED/PLAYING). Fixes #3371 Part-of: --- subprojects/gst-plugins-base/gst/playback/gstplaybin3.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c b/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c index a24186ad32..1df2357e8a 100644 --- a/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c +++ b/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c @@ -1200,11 +1200,6 @@ invalid: static void gst_play_bin3_set_uri (GstPlayBin3 * playbin, const gchar * uri) { - if (uri == NULL) { - g_warning ("cannot set NULL uri"); - return; - } - if (!gst_playbin_uri_is_valid (playbin, uri)) { if (g_str_has_prefix (uri, "file:")) { GST_WARNING_OBJECT (playbin, "not entirely correct file URI '%s' - make "