From 0c84b1b10430406975ec401f88a40edfb942f854 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 12 Apr 2016 15:00:31 +0300 Subject: [PATCH] deinterlace: Instead of confusing crashes later, just error out immediately if mapping a video frame fails This probably still crashes but at least we get some hint about what goes wrong instead of random behaviour later. --- gst/deinterlace/gstdeinterlace.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gst/deinterlace/gstdeinterlace.c b/gst/deinterlace/gstdeinterlace.c index 987c4eda87..e4e16542f4 100644 --- a/gst/deinterlace/gstdeinterlace.c +++ b/gst/deinterlace/gstdeinterlace.c @@ -744,7 +744,11 @@ gst_video_frame_new_and_map (GstVideoInfo * vinfo, GstBuffer * buffer, GstMapFlags flags) { GstVideoFrame *frame = g_malloc0 (sizeof (GstVideoFrame)); - gst_video_frame_map (frame, vinfo, buffer, flags); + if (!gst_video_frame_map (frame, vinfo, buffer, flags)) { + g_free (frame); + g_return_val_if_reached (NULL); + return NULL; + } return frame; }