From 078958bd6bb6f5de1a8e57d434d691f5e7827134 Mon Sep 17 00:00:00 2001 From: Sebastian Rasmussen Date: Sat, 9 Aug 2014 13:24:00 +0200 Subject: [PATCH] pvrvideosink: Avoid leaking bufferpool configuration gst_buffer_pool_get_config() returns a copy to the bufferpool's configuration, which must be passed to gst_structure_free() after use if not given away to gst_buffer_pool_set_config(). Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734537 --- sys/pvr2d/gstpvrvideosink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/pvr2d/gstpvrvideosink.c b/sys/pvr2d/gstpvrvideosink.c index 017bec6f4d..7dc30c1b05 100644 --- a/sys/pvr2d/gstpvrvideosink.c +++ b/sys/pvr2d/gstpvrvideosink.c @@ -994,6 +994,7 @@ gst_pvrvideosink_propose_allocation (GstBaseSink * bsink, GstQuery * query) GST_DEBUG_OBJECT (pvrvideosink, "check existing pool caps"); config = gst_buffer_pool_get_config (pool); gst_buffer_pool_config_get (config, &pcaps, &size, NULL, NULL, NULL, NULL); + gst_structure_free (config); if (!gst_caps_is_equal (caps, pcaps)) { GST_DEBUG_OBJECT (pvrvideosink, "pool has different caps");