FaSTTUBe/GST-Tensordecoder-ov_ep
37
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

qtwrapper: Replace the hackish 42 magic number with a define

Browse Source
This commit is contained in:
Martin Storsjo 2011-05-03 14:14:20 +03:00 committed by Sebastian Dröge
parent efd840bbb7
commit 02fc41fde5
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/qtwrapper/audiodecoders.c
View File

@ -62,6 +62,8 @@
#define QTWRAPPER_ADEC_PARAMS_QDATA g_quark_from_static_string("qtwrapper-adec-params") #define QTWRAPPER_ADEC_PARAMS_QDATA g_quark_from_static_string("qtwrapper-adec-params")
#define NO_MORE_INPUT_DATA 42
static GstStaticPadTemplate src_templ = GST_STATIC_PAD_TEMPLATE ("src", static GstStaticPadTemplate src_templ = GST_STATIC_PAD_TEMPLATE ("src",
GST_PAD_SRC, GST_PAD_SRC,
GST_PAD_ALWAYS, GST_PAD_ALWAYS,
@ -745,9 +747,9 @@ process_buffer_cb (ComponentInstance inAudioConverter,
return noErr; return noErr;
} }
GST_LOG_OBJECT (qtwrapper, "No remaining input data, returning 42 for hack"); GST_LOG_OBJECT (qtwrapper, "No remaining input data, returning NO_MORE_INPUT_DATA");
return 42; return NO_MORE_INPUT_DATA;
} }
static GstFlowReturn static GstFlowReturn
@ -805,8 +807,7 @@ qtwrapper_audio_decoder_chain (GstPad * pad, GstBuffer * buf)
(SCAudioInputDataProc) process_buffer_cb, (SCAudioInputDataProc) process_buffer_cb,
qtwrapper, (UInt32 *) & outsamples, qtwrapper->bufferlist, NULL); qtwrapper, (UInt32 *) & outsamples, qtwrapper->bufferlist, NULL);
/* TODO: What's this '42' crap?? It does seem to be needed, though. */ if ((status != noErr) && (status != NO_MORE_INPUT_DATA)) {
if ((status != noErr) && (status != 42)) {
if (status < 0) if (status < 0)
GST_WARNING_OBJECT (qtwrapper, GST_WARNING_OBJECT (qtwrapper,
"Error in SCAudioFillBuffer() : %d", (gint32) status); "Error in SCAudioFillBuffer() : %d", (gint32) status);