From 02dce71d952706418e79c8b6e0798a35045c1b18 Mon Sep 17 00:00:00 2001
From: Jordan Petridis <jordan@centricular.com>
Date: Mon, 24 May 2021 23:11:10 +0300
Subject: [PATCH] ci_template: mark the manifest job as not allowed to fail

With gitlab 13.12 the behavior of jobs that depend of manual
jobs changes, and they are considered skipped by default.

But in our pipeline we want to enforce that the whole pipeline
runs and succeds and the manual status is only there to reduce
CI load.

For more details see:

https://about.gitlab.com/blog/2021/05/20/dag-manual-fix/

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-ci/-/merge_requests/404>
---
 gitlab/ci_template.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gitlab/ci_template.yml b/gitlab/ci_template.yml
index ed52fe5ef0..d543c9c835 100644
--- a/gitlab/ci_template.yml
+++ b/gitlab/ci_template.yml
@@ -383,10 +383,12 @@ manifest:
     # to avoid wasting CI resources
     - if: '$CI_MERGE_REQUEST_ASSIGNEES != "gstreamer-merge-bot"'
       when: 'manual'
+      allow_failure: false
     # If this matches, it means the pipeline is running against either the main
     # or a stable branch, so make it manual
     - if: '$CI_COMMIT_BRANCH == $GST_UPSTREAM_BRANCH'
       when: 'manual'
+      allow_failure: false
 
   stage: 'preparation'
   script: